added constants package for all constants#2076
Draft
JimmyLeeJonesOG wants to merge 2 commits intodata-for-change:devfrom
Draft
added constants package for all constants#2076JimmyLeeJonesOG wants to merge 2 commits intodata-for-change:devfrom
JimmyLeeJonesOG wants to merge 2 commits intodata-for-change:devfrom
Conversation
Took all the (inner) classes in BE consts + constants.py and split/put them in dedicated .py files, one for each class (except for inner classes in BE consts)
Codecov Report
@@ Coverage Diff @@
## dev #2076 +/- ##
==========================================
+ Coverage 51.85% 52.36% +0.51%
==========================================
Files 100 110 +10
Lines 7942 8059 +117
==========================================
+ Hits 4118 4220 +102
- Misses 3824 3839 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
atalyaalon
approved these changes
Jan 15, 2022
Collaborator
|
@shaysw looks good, there is a small conflict in user_system/api.py file - can you resolve? |
Collaborator
|
@shaysw What do you think about that: |
ziv17
reviewed
Jan 16, 2022
| from flask_babel import _ | ||
|
|
||
|
|
||
| class BackEndConstants(object): |
Collaborator
There was a problem hiding this comment.
As we are doing a big change, I do not see value in having the constants in this file inside a class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Took all the (inner) classes in BE consts + constants.py and split/put them in dedicated .py files, one for each class (except for inner classes in BE consts)