Added a new end point that determines a road type according to lon and lat#1583
Added a new end point that determines a road type according to lon and lat#1583LLnaki wants to merge 1 commit intodata-for-change:devfrom
Conversation
…d lat coordinates.
Codecov Report
@@ Coverage Diff @@
## dev #1583 +/- ##
==========================================
- Coverage 52.71% 51.09% -1.62%
==========================================
Files 62 62
Lines 6031 6012 -19
==========================================
- Hits 3179 3072 -107
- Misses 2852 2940 +88
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
atalyaalon
left a comment
atalyaalon
left a comment
There was a problem hiding this comment.
Great Work!
I added some comments for you to address - what do you think?
| def get_id(self): | ||
| return self.id | ||
|
|
||
| class WazeAllerts(Base): |
There was a problem hiding this comment.
Waze alerts table exists (See class WazeAlert in this file)
What there's a need in another one?
| from sys import maxsize | ||
| @user_optional | ||
| def get_road_type(lat: float, lon: float): | ||
| offset = 0.00001 |
There was a problem hiding this comment.
How did you decide on the offset size (0.00001)?
In general - I suggest using geographical query instead of the query below -see geom.intersects here
In this case - I think that using both the geographical query and the road_number / street name together can be very powerful - just using one of them is not enought.
However - we can start with geographical query and improve it.
2 participants
No description provided.