Install pickle5 in Python 3.7 CI jobs #5302
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
force-pushed
the
ci_py37_pickle5
branch
from
c7367ff to
e191f7e
Compare
jakirkham
commented
Sep 9, 2021
| shell: bash -l {0} | ||
| # pickle5 is used for out-of-band pickling support in Python 3.7 | ||
| if: ${{ matrix.os == 'ubuntu-latest' && matrix.python-version < '3.8' }} | ||
| run: mamba install -c conda-forge pickle5 |
Member
Author
There was a problem hiding this comment.
It might be worth limiting this to only some Python 3.7 CI jobs given it is still useful to test without pickle5. Though it would be good to have some Python 3.7 jobs that include this.
Not sure how we want to handle that (see partitions above, which might be a useful way to handle this). Though maybe there are better ways.
Member
Author
There was a problem hiding this comment.
Addressed by testing both pickle protocol 4 & 5 in PR ( #5313 ).
Member
Author
|
Nvm looks like it is already installed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black distributed/flake8 distributed/isort distributedMake sure that
pickle5is installed in Python 3.7 CI jobs so that code path can be tested.