Skip to content

Generalize get_dummies#1053

Merged
phofl merged 2 commits intodask:mainfrom
rjzamora:fix-get_dummies
May 2, 2024
Merged

Generalize get_dummies#1053
phofl merged 2 commits intodask:mainfrom
rjzamora:fix-get_dummies

Conversation

@rjzamora
Copy link
Copy Markdown
Member

@rjzamora rjzamora commented May 2, 2024

  • Generalizes get_dummies/GetDummies to work with cudf
  • Fixes a minor bug (missing "sparse" parameter)

@rjzamora rjzamora added the bug Something isn't working label May 2, 2024
@rjzamora rjzamora self-assigned this May 2, 2024
@phofl
Copy link
Copy Markdown
Collaborator

phofl commented May 2, 2024

I suppose we can't add a test here?

@rjzamora
Copy link
Copy Markdown
Member Author

rjzamora commented May 2, 2024

I suppose we can't add a test here?

This is a good question. I updated the test to work with both pandas and cudf.

Not sure if we want to add test coverage for the parameters?

@phofl
Copy link
Copy Markdown
Collaborator

phofl commented May 2, 2024

I think that's fine, it would be covered by the gpu ci, correct?

@phofl phofl merged commit 2f659ee into dask:main May 2, 2024
@phofl
Copy link
Copy Markdown
Collaborator

phofl commented May 2, 2024

thx

@rjzamora
Copy link
Copy Markdown
Member Author

rjzamora commented May 2, 2024

it would be covered by the gpu ci, correct?

I'm working on this :)

@rjzamora rjzamora deleted the fix-get_dummies branch May 2, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants