Conversation
dask_expr/_collection.py
Outdated
| meta = make_meta( | ||
| meta_nonempty(self._meta).melt( | ||
| id_vars=id_vars, | ||
| value_vars=value_vars, | ||
| var_name=var_name, | ||
| value_name=value_name, | ||
| col_level=col_level, | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Probably don't need this.
There was a problem hiding this comment.
Can you confirm this? Wouldn't want to merge it if we don't need it.
There was a problem hiding this comment.
Okay yeah. Default emulation works fine for the tests - Removing the unnecessary logic.
| dict(value_vars=["s1", "s2"]), | ||
| ], | ||
| ) | ||
| def test_melt(kwargs): |
There was a problem hiding this comment.
Test copied from dask/dask for now.
phofl
left a comment
phofl
left a comment
There was a problem hiding this comment.
Did you run the dask/dask melt tests on this to make sure that all of them are passing?
We'd also need a PR that enables those tests on CI
dask_expr/_collection.py
Outdated
| meta = make_meta( | ||
| meta_nonempty(self._meta).melt( | ||
| id_vars=id_vars, | ||
| value_vars=value_vars, | ||
| var_name=var_name, | ||
| value_name=value_name, | ||
| col_level=col_level, | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Can you confirm this? Wouldn't want to merge it if we don't need it.
|
Thanks for the review @phofl ! Sorry - Should have marked this as a draft. I was curious why |
phofl
left a comment
phofl
left a comment
There was a problem hiding this comment.
lgtm
can you add it to the api docs as well if not already done in your other PR?
|
thx |
2 participants
Closes #1002
dask/dask component: dask/dask#11088
I'm not really sure if
melthas been left out of the API for a specific reason. This PR adds basic support usingmap_partitions.