Datafusion filter #581
Datafusion filter #581
Conversation
Codecov Report
@@ Coverage Diff @@
## datafusion-sql-planner #581 +/- ##
=========================================================
Coverage ? 60.80%
=========================================================
Files ? 72
Lines ? 3572
Branches ? 729
=========================================================
Hits ? 2172
Misses ? 1249
Partials ? 151 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
jdye64
requested review from
ayushdg,
charlesbluca and
galipremsagar
as code owners
ayushdg
left a comment
ayushdg
left a comment
There was a problem hiding this comment.
Generally changes lgtm!
We need to add more testing around different date time arithmetic and operations. We can probably do it in a followup pr but should open an issue for tracking.
Especially for cases where sql interval types are being added/subtracted from dates/timestamps
wence-
left a comment
wence-
left a comment
There was a problem hiding this comment.
Some comments/suggestions
ayushdg
left a comment
ayushdg
left a comment
There was a problem hiding this comment.
Based on the discussion in #581 (comment) is it right to assume that this pr only handles datetime objects for now and a followup pr will be opened to handle #584?
Yes, that is correct |
charlesbluca
left a comment
charlesbluca
left a comment
There was a problem hiding this comment.
One more comment but otherwise LGTM
|
rerun tests |
7 participants
Closes: #463
Closes: #459