-
Notifications
You must be signed in to change notification settings - Fork 72
Datafusion aggregate #471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
charlesbluca
merged 94 commits into
dask-contrib:datafusion-sql-planner
from
jdye64:datafusion-aggregate
Apr 21, 2022
Merged
Datafusion aggregate #471
Changes from all commits
Commits
Show all changes
94 commits
Select commit
Hold shift + click to select a range
23603de
Add basic predicate-pushdown optimization (#433)
rjzamora 09c7bdf
Add workflow to keep datafusion dev branch up to date (#440)
charlesbluca 9038b85
Condition for BinaryExpr, filter, input_ref, rexcall, and rexliteral
jdye64 2d16579
Updates for test_filter
jdye64 a4aeee5
more of test_filter.py working with the exception of some date pytests
jdye64 f6f8061
Updates to dates and parsing dates like postgresql does
jdye64 1b0b6f7
Update gpuCI `RAPIDS_VER` to `22.06` (#434)
github-actions[bot] a05138d
Bump black to 22.3.0 (#443)
charlesbluca ab2aa5a
Check for ucx-py nightlies when updating gpuCI (#441)
charlesbluca 8eb70bb
Refactored to adjust for better type management
jdye64 d7d86c7
Refactor schema and statements
jdye64 812e85e
update types
jdye64 e04365b
fix syntax issues and renamed function name calls
jdye64 a28f757
Add handling for newer `prompt_toolkit` versions in cmd tests (#447)
charlesbluca 486fc66
Fix version for gha-find-replace (#446)
charlesbluca f0e1cbb
Improved error handling and code clean up
jdye64 36909dd
move pieces of logical.rs to seperated files to ensure code readability
jdye64 d1ea26a
left join working
jdye64 ce176e0
Update versions of Java dependencies (#445)
ayushdg 50d95d2
Update jackson databind version (#449)
ayushdg 37a3a61
Disable SQL server functionality (#448)
charlesbluca ffdc42f
Update dask pinnings for release (#450)
charlesbluca fa74aef
Add Java source code to source distribution (#451)
charlesbluca 37ea6b6
Bump `httpclient` dependency (#453)
charlesbluca f19ee4d
Unpin Dask/distributed versions (#452)
charlesbluca 1eb30c1
Add jsonschema to ci testing (#454)
ayushdg 2bd1d18
Switch tests from `pd.testing.assert_frame_equal` to `dd.assert_eq` (…
charlesbluca 263fdba
First basic working checkpoint for group by
jdye64 95b0dd0
Set max pin on antlr4-python-runtime (#456)
ayushdg 1077da2
Updates to style
jdye64 653f6a8
stage pre-commit changes for upstream merge
jdye64 f53d24d
Merge with upstream/main
jdye64 78d59f0
Fix black failures
charlesbluca 84f6b1d
Updates to Rust formatting
jdye64 ac6cf3a
Merge remote-tracking branch 'origin/datafusion-aggregate' into dataf…
jdye64 1ac78a5
Fix rust lint and clippy
jdye64 e38d9d2
Remove jar building step which is no longer needed
jdye64 c3da3e5
Remove Java from github workflows matrix
jdye64 d8450b6
Removes jar and Java references from test.yml
jdye64 a297185
Update Release workflow to remove references to Java
jdye64 54ddf39
Update rust.yml to remove references from linux-build-lib
jdye64 f3c9a5b
Add pre-commit.sh file to provide pre-commit support for Rust in a co…
jdye64 9bce14c
Removed overlooked jdk references
jdye64 c975304
cargo clippy auto fixes
jdye64 4ca5963
Address all Rust clippy warnings
jdye64 866f815
Include setuptools-rust in conda build recipie
jdye64 10f4550
Include setuptools-rust in conda build recipie, in host and run
jdye64 f4cf13d
Adjustments for conda build, committing for others to help with error…
jdye64 3e4dcbd
Include sql.yaml in package files
jdye64 f50d4eb
Include pyarrow in run section of conda build to ensure tests pass
jdye64 4483c5e
include setuptools-rust in host and run of conda since removing cause…
jdye64 9936c92
to_string() method had been removed in rust and not removed here, cau…
jdye64 17762cb
Replace commented out tests with pytest.skip and bump version of pyar…
jdye64 8f0ba93
Fix setup.py syntax issue introduced on last commit by find/replace
jdye64 7691bb2
Rename Datafusion -> DataFusion and Apache DataFusion -> Arrow DataFu…
jdye64 e7690ba
Fix docs build environment
jdye64 c3b905e
Include Rust compiler in docs environment
jdye64 9436f7d
Bump Rust compiler version to 1.59
jdye64 a3b43c0
Ok, well readthedocs didn't like that
jdye64 1fe10f0
Store libdask_planner.so and retrieve it between github workflows
jdye64 f4ad591
Cache the Rust library binary
jdye64 bb4d2c3
Remove Cargo.lock from git
jdye64 4cc1450
Remove unused datafusion-expr crate
jdye64 2251663
Build datafusion at each test step instead of caching binaries
jdye64 d12004d
Remove maven and jar cache steps from test-upstream.yaml
jdye64 e81a0c6
Removed dangling 'build' workflow step reference
jdye64 9293359
Lowered PyArrow version to 6.0.1 since cudf has a hard requirement on…
jdye64 24d057f
Add Rust build step to test in dask cluster
jdye64 e71e476
Install setuptools-rust for pip to use for bare requirements import
jdye64 0728c61
Include pyarrow 6.0.1 via conda as a bare minimum dependency
jdye64 496ba8d
Remove cudf dependency for python 3.9 which is causing build issues o…
jdye64 ed330b3
Address documentation from review
jdye64 542fc21
Install Rust as readthedocs post_create_environment step
jdye64 fc4d08b
Run rust install non-interactively
jdye64 d9cca16
Run rust install non-interactively
jdye64 a6030b9
Rust isn't available in PyPi so remove that dependency
jdye64 c82c062
Append ~/.cargo/bin to the PATH
jdye64 a6c3de6
Print out some environment information for debugging
jdye64 8aad550
Print out some environment information for debugging
jdye64 04fb814
More - Increase verbosity
jdye64 d6bea9d
More - Increase verbosity
jdye64 e24b77f
More - Increase verbosity
jdye64 f2a1071
Switch RTD over to use Conda instead of Pip since having issues with …
jdye64 f00d498
Try to use mamba for building docs environment
jdye64 02f05b5
Partial review suggestion address, checking CI still works
jdye64 0e53eab
Skip mistakenly enabled tests
jdye64 991cc5a
Use DataFusion master branch, and fix syntax issues related to the ve…
jdye64 daa7ee0
More updates after bumping DataFusion version to master
jdye64 3c83833
Use actions-rs in github workflows debug flag for setup.py
jdye64 1f704dd
Remove setuptools-rust from conda
jdye64 58c452d
Use re-exported Rust types for BuiltinScalarFunction
jdye64 2a9e9a5
Move python imports to TYPE_CHECKING section where applicable
jdye64 92d357b
Address review concerns and remove pre-commit.sh file
jdye64 9fc4fc3
Pin to a specific github rev for DataFusion
jdye64 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,39 +13,70 @@ jobs: | |
| steps: | ||
| - uses: actions/checkout@v2 | ||
|
|
||
| - name: Parse current axis YAML | ||
| uses: the-coding-turtle/[email protected] | ||
| with: | ||
| file: continuous_integration/gpuci/axis.yaml | ||
|
|
||
| - name: Get latest cuDF nightly version | ||
| id: latest_version | ||
| id: cudf_latest | ||
| uses: jacobtomlinson/[email protected] | ||
| with: | ||
| org: "rapidsai-nightly" | ||
| package: "cudf" | ||
| version_system: "CalVer" | ||
|
|
||
| - name: Strip git tags from versions | ||
| - name: Get latest cuML nightly version | ||
| id: cuml_latest | ||
| uses: jacobtomlinson/[email protected] | ||
| with: | ||
| org: "rapidsai-nightly" | ||
| package: "cuml" | ||
| version_system: "CalVer" | ||
|
|
||
| - name: Get latest UCX-Py nightly version | ||
| id: ucx_py_latest | ||
| uses: jacobtomlinson/[email protected] | ||
| with: | ||
| org: "rapidsai-nightly" | ||
| package: "ucx-py" | ||
| version_system: "CalVer" | ||
|
|
||
| - name: Get old RAPIDS / UCX-Py versions | ||
| env: | ||
| FULL_RAPIDS_VER: ${{ steps.latest_version.outputs.version }} | ||
| run: echo "RAPIDS_VER=${FULL_RAPIDS_VER::-10}" >> $GITHUB_ENV | ||
| FULL_CUDF_VER: ${{ steps.cudf_latest.outputs.version }} | ||
| FULL_CUML_VER: ${{ steps.cuml_latest.outputs.version }} | ||
| FULL_UCX_PY_VER: ${{ steps.ucx_py_latest.outputs.version }} | ||
| run: | | ||
| echo RAPIDS_VER=$RAPIDS_VER_0 >> $GITHUB_ENV | ||
| echo UCX_PY_VER=$(curl -sL https://version.gpuci.io/rapids/$RAPIDS_VER_0) >> $GITHUB_ENV | ||
| echo NEW_CUDF_VER=${FULL_CUDF_VER::-10} >> $GITHUB_ENV | ||
| echo NEW_CUML_VER=${FULL_CUML_VER::-10} >> $GITHUB_ENV | ||
| echo NEW_UCX_PY_VER=${FULL_UCX_PY_VER::-10} >> $GITHUB_ENV | ||
|
|
||
| - name: Find and Replace Release | ||
| uses: jacobtomlinson/gha-find-replace@0.1.4 | ||
| - name: Update RAPIDS version | ||
| uses: jacobtomlinson/gha-find-replace@v2 | ||
| with: | ||
| include: 'continuous_integration\/gpuci\/axis\.yaml' | ||
| find: "RAPIDS_VER:\n- .*" | ||
| replace: |- | ||
| RAPIDS_VER: | ||
| - "${{ env.RAPIDS_VER }}" | ||
| find: "${{ env.RAPIDS_VER }}" | ||
| replace: "${{ env.NEW_CUDF_VER }}" | ||
| regex: false | ||
|
|
||
| - name: Create Pull Request | ||
| uses: peter-evans/create-pull-request@v3 | ||
| # make sure ucx-py nightlies are available and that cuDF/cuML nightly versions match up | ||
| if: | | ||
| env.UCX_PY_VER != env.NEW_UCX_PY_VER && | ||
| env.NEW_CUDF_VER == env.NEW_CUML_VER | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| draft: true | ||
| commit-message: "Update gpuCI `RAPIDS_VER` to `${{ env.RAPIDS_VER }}`" | ||
| title: "Update gpuCI `RAPIDS_VER` to `${{ env.RAPIDS_VER }}`" | ||
| commit-message: "Update gpuCI `RAPIDS_VER` to `${{ env.NEW_CUDF_VER }}`" | ||
| title: "Update gpuCI `RAPIDS_VER` to `${{ env.NEW_CUDF_VER }}`" | ||
| team-reviewers: "dask/gpu" | ||
| author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> | ||
| branch: "upgrade-gpuci-rapids" | ||
| body: | | ||
| A new cuDF nightly version has been detected. | ||
| New cuDF and ucx-py nightly versions have been detected. | ||
|
|
||
| Updated `axis.yaml` to use `${{ env.RAPIDS_VER }}`. | ||
| Updated `axis.yaml` to use `${{ env.NEW_CUDF_VER }}`. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -60,3 +60,4 @@ dask_sql/jar | |
| dask-worker-space/ | ||
| node_modules/ | ||
| docs/source/_build/ | ||
| dask_planner/Cargo.lock | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.