-
Notifications
You must be signed in to change notification settings - Fork 72
Update docs theme, use sphinx-tabs for CPU/GPU examples #394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #394 +/- ##
==========================================
+ Coverage 89.02% 89.17% +0.15%
==========================================
Files 69 69
Lines 3326 3326
Branches 653 653
==========================================
+ Hits 2961 2966 +5
+ Misses 296 287 -9
- Partials 69 73 +4
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
@VibhuJawa if you get a chance could you check out |
Looking at it right now. We need to add to do two things:
Will make a PR with the suggested changes to this PR in a bit. |
|
@charlesbluca , Raised a PR herre charlesbluca#2 . Also, looking at the other sections (see below) of the machine-learning docs, they should probably work with What do you think ? |
Update `dask-ml` GPU docs
|
Raised #397 to track the update to other ML sections. |
|
That sounds good to me - I can make TODOs for those examples so that we can remember to add GPU sections there in a follow up. It's not immediately obvious what code changes would be made to example 6 to account for GPUs - or is the idea that a model created with a cuML class should have no issues being exported? |
Depends on the model, i think most models work but some models like FIL have issues . We would have to test it to know. Anyways, having this under CI will give us confidence after putting stuff under CI.
Yup. Raised issue to track this, #397 . Lets add stuff there. :-) |
|
Going to go ahead and merge this in, as the gpuCI failures are unrelated |
This PR bumps the
dask-sphinx-themeto be more in line with Dask / Distributed's docs, and adds thesphinx-tabsextension so that code-blocks can be tabbed to show their GPU equivalent (when possible)