Skip to content

Conversation

@jdye64
Copy link
Collaborator

@jdye64 jdye64 commented Jan 31, 2022

… disabled for a context

Copy link
Collaborator

@randerzander randerzander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the intent here is to allow users to turn off specific CBO rules which may be problematic, we'll need a place where they can see how to configure them, and what constants/enums they need to supply.

I think this is as good a time as any to start the beginnings of a docs page about Dask-SQL's use of Calcite's CBO.

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2022

Codecov Report

Merging #389 (78f5e90) into main (f601325) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #389      +/-   ##
==========================================
+ Coverage   88.94%   89.09%   +0.14%     
==========================================
  Files          68       68              
  Lines        3337     3337              
  Branches      653      653              
==========================================
+ Hits         2968     2973       +5     
+ Misses        298      289       -9     
- Partials       71       75       +4     
Impacted Files Coverage Δ
dask_sql/context.py 100.00% <100.00%> (ø)
dask_sql/_version.py 34.00% <0.00%> (+1.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f601325...78f5e90. Read the comment docs.

Copy link
Collaborator

@charlesbluca charlesbluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the work @jdye64! Could we maybe open an issue to track the follow up work that needs to happen here?

@charlesbluca charlesbluca merged commit 6c7c761 into dask-contrib:main Feb 15, 2022
@jdye64 jdye64 deleted the disable_specified_cbo_rules branch February 16, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants