-
Notifications
You must be signed in to change notification settings - Fork 72
Enable ability for user to pass in a list of CBO rules that should be… #389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ability for user to pass in a list of CBO rules that should be… #389
Conversation
… disabled for a context
planner/src/main/java/com/dask/sql/application/RelationalAlgebraGeneratorBuilder.java
Outdated
Show resolved
Hide resolved
planner/src/main/java/com/dask/sql/application/DaskPlanner.java
Outdated
Show resolved
Hide resolved
randerzander
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the intent here is to allow users to turn off specific CBO rules which may be problematic, we'll need a place where they can see how to configure them, and what constants/enums they need to supply.
I think this is as good a time as any to start the beginnings of a docs page about Dask-SQL's use of Calcite's CBO.
Codecov Report
@@ Coverage Diff @@
## main #389 +/- ##
==========================================
+ Coverage 88.94% 89.09% +0.14%
==========================================
Files 68 68
Lines 3337 3337
Branches 653 653
==========================================
+ Hits 2968 2973 +5
+ Misses 298 289 -9
- Partials 71 75 +4
Continue to review full report at Codecov.
|
planner/src/main/java/com/dask/sql/application/RelationalAlgebraGenerator.java
Outdated
Show resolved
Hide resolved
…sql into disable_specified_cbo_rules
charlesbluca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the work @jdye64! Could we maybe open an issue to track the follow up work that needs to happen here?
… disabled for a context