Skip to content

Don't persist dataframes before applying offset / limit #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charlesbluca merged 1 commit into from
Jan 28, 2022
Merged

Don't persist dataframes before applying offset / limit #387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion dask_sql/physical/rel/logical/limit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ def _apply_offset(self, df: dd.DataFrame, offset: int, end: int) -> dd.DataFrame
we need to pass the partition number to the selection
function, which is not possible with normal "map_partitions".
"""
df = df.persist()
if not offset:
# We do a (hopefully) very quick check: if the first partition
# is already enough, we will just use this
Expand Down