Skip to content

Conversation

@charlesbluca
Copy link
Collaborator

In pandas 1.4.0, the BaseIndexer was relocated from pandas.core.window.indexers to pandas.core.indexers.objects, breaking CI as seen in https://github.com/dask-contrib/dask-sql/actions/runs/1737510437.

This PR fixes this import to use pandas.api.indexers, which should work for pandas versions both before and after this relocation.

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2022

Codecov Report

Merging #377 (d2f1e2b) into main (ec97bee) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
+ Coverage   95.58%   95.60%   +0.01%     
==========================================
  Files          67       67              
  Lines        2923     2932       +9     
  Branches      546      546              
==========================================
+ Hits         2794     2803       +9     
  Misses         79       79              
  Partials       50       50              
Impacted Files Coverage Δ
dask_sql/physical/rel/logical/window.py 98.83% <100.00%> (ø)
dask_sql/utils.py 100.00% <0.00%> (ø)
dask_sql/context.py 100.00% <0.00%> (ø)
dask_sql/physical/rex/core/call.py 99.12% <0.00%> (+<0.01%) ⬆️
dask_sql/server/responses.py 97.87% <0.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec97bee...d2f1e2b. Read the comment docs.

@charlesbluca charlesbluca merged commit d685432 into dask-contrib:main Jan 24, 2022
@charlesbluca charlesbluca deleted the fix-pandas-base-indexer branch July 19, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants