Skip to content

Conversation

@charlesbluca
Copy link
Collaborator

Until another version of dask-ml is released, test_iterative_and_prediction and test_show_models will fail due to the breakage discussed in dask/dask-ml#894; this PR xfails those tests to unblock CI for now until that new version is out, after which we will want to bump our dask-ml dependency.

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2022

Codecov Report

Merging #373 (9b8b617) into main (cf3c076) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
- Coverage   95.60%   95.46%   -0.14%     
==========================================
  Files          67       67              
  Lines        2932     2932              
  Branches      546      546              
==========================================
- Hits         2803     2799       -4     
- Misses         79       83       +4     
  Partials       50       50              
Impacted Files Coverage Δ
dask_sql/physical/rel/custom/show_models.py 53.33% <0.00%> (-26.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf3c076...9b8b617. Read the comment docs.

@charlesbluca charlesbluca merged commit bba282a into dask-contrib:main Jan 19, 2022
@charlesbluca charlesbluca deleted the xfail-ml-tests branch July 19, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants