Skip to content

Add substr tests #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charlesbluca merged 3 commits into from
Jan 24, 2022
Merged

Add substr tests #372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58fa4e2
Add tests for SUBSTR string function
ayushdg Jan 19, 2022
636901b
Replace the use of deprecated distuils.version.LooseVersion with pack…
ayushdg Jan 19, 2022
420ffa9
Rerun tests
ayushdg Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions dask_sql/_compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
from distutils.version import LooseVersion

import pandas as pd
from packaging.version import parse as parseVersion

_pandas_version = LooseVersion(pd.__version__)
FLOAT_NAN_IMPLEMENTED = _pandas_version >= LooseVersion("1.2.0")
INT_NAN_IMPLEMENTED = _pandas_version >= LooseVersion("1.0.0")
_pandas_version = parseVersion(pd.__version__)
FLOAT_NAN_IMPLEMENTED = _pandas_version >= parseVersion("1.2.0")
INT_NAN_IMPLEMENTED = _pandas_version >= parseVersion("1.0.0")
1 change: 1 addition & 0 deletions tests/integration/test_postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ def test_string_operations(assert_query_gives_same_result):
SUBSTRING(s FROM 10),
SUBSTRING(s FROM 2),
SUBSTRING(s FROM 2 FOR 2),
SUBSTR(s,2,2),
INITCAP(s),
INITCAP(UPPER(s)),
INITCAP(LOWER(s))
Expand Down
10 changes: 6 additions & 4 deletions tests/integration/test_rex.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,9 +464,10 @@ def test_string_functions(c, gpu):
SUBSTRING(a FROM 10) AS p,
SUBSTRING(a FROM 2) AS q,
SUBSTRING(a FROM 2 FOR 2) AS r,
INITCAP(a) AS s,
INITCAP(UPPER(a)) AS t,
INITCAP(LOWER(a)) AS u
SUBSTR(a, 3, 6) AS s,
INITCAP(a) AS t,
INITCAP(UPPER(a)) AS u,
INITCAP(LOWER(a)) AS v
FROM
{input_table}
"""
Expand Down Expand Up @@ -496,9 +497,10 @@ def test_string_functions(c, gpu):
"p": ["string"],
"q": [" normal string"],
"r": [" n"],
"s": ["A Normal String"],
"s": ["normal"],
"t": ["A Normal String"],
"u": ["A Normal String"],
"v": ["A Normal String"],
}
)

Expand Down