Skip to content

Conversation

@jdye64
Copy link
Collaborator

@jdye64 jdye64 commented Jan 14, 2022

This closes #367

@jdye64 jdye64 changed the title Modified show.ftl to conditionally expect FROM in parsing logic [REVIEW] Modified show.ftl to conditionally expect FROM in parsing logic Jan 14, 2022
@jdye64
Copy link
Collaborator Author

jdye64 commented Jan 15, 2022

rerun tests

@charlesbluca
Copy link
Collaborator

Your changes are working, but CI is broken because of downstream breakage in dask-ml

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2022

Codecov Report

Merging #371 (c988721) into main (1732f75) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
+ Coverage   88.91%   89.07%   +0.15%     
==========================================
  Files          68       68              
  Lines        3330     3333       +3     
  Branches      650      651       +1     
==========================================
+ Hits         2961     2969       +8     
+ Misses        298      289       -9     
- Partials       71       75       +4     
Impacted Files Coverage Δ
dask_sql/physical/rel/custom/tables.py 85.71% <100.00%> (+2.38%) ⬆️
dask_sql/_version.py 34.00% <0.00%> (+1.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1732f75...c988721. Read the comment docs.

@charlesbluca charlesbluca merged commit 34fee74 into dask-contrib:main Feb 14, 2022
@jdye64 jdye64 deleted the show_tables branch May 16, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENH] Support "show tables" metadata query

3 participants