Skip to content

Conversation

@charlesbluca
Copy link
Collaborator

In advance of our next release, removes the max version restriction for Dask/Distributed so that we can check for potential compatibility issues (specifically those raised in #350 since dask-ml hasn't cut a release since @ayushdg's fix)

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2022

Codecov Report

Merging #369 (0af0a25) into main (286681f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #369   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files          67       67           
  Lines        2935     2935           
  Branches      547      547           
=======================================
  Hits         2805     2805           
  Misses         79       79           
  Partials       51       51           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 286681f...0af0a25. Read the comment docs.

Copy link
Collaborator

@ayushdg ayushdg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes. I suspect things will work now since dask hasn't cut a release since the changes that broke dask-ml merged in. But I believe the dask community is planning a release sometime this/next week and I suspect we'll see some failures seen in #350 until a dask-ml release.

@charlesbluca charlesbluca merged commit 408f976 into dask-contrib:main Jan 14, 2022
@charlesbluca charlesbluca deleted the unrestrict-dask branch January 19, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants