[REVIEW] Fix unary conditional join operations

[jdye64]

No description provided.

[codecov-commenter]

Codecov Report

Merging #366 (5843594) into main (631eb82) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #366   +/-   ##
=======================================
  Coverage   95.60%   95.60%           
=======================================
  Files          67       67           
  Lines        2932     2933    +1     
  Branches      546      547    +1     
=======================================
+ Hits         2803     2804    +1     
  Misses         79       79           
  Partials       50       50           

Impacted Files	Coverage Δ
dask_sql/physical/rel/logical/join.py	98.31% <100.00%> (+0.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 631eb82...5843594. Read the comment docs.

[charlesbluca]

Thanks for digging into this @jdye64 🙂 couple comments around the test:

[charlesbluca]

Thanks for the work here @jdye64! LGTM

[randerzander]

I believe this is intended to fix a StackOverflow condition when running q14.

Unfortunately even when I include this fix, I still get a hang and the DAG is never fully generated. I suspect this may be another CBO infinite loop?

[randerzander]

With @jdye64 's latest changes here, the query works again as expected.

This is good to merge from my perspective.

[charlesbluca]

Failures seem to be related to CodeCov and not actual tests failing - going to merge this in. Thanks again @jdye64!