Skip to content

Add os environment option to enable remote jvm debugging #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
galipremsagar merged 1 commit into from
Jan 10, 2022
Merged

Add os environment option to enable remote jvm debugging #363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions dask_sql/java.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,25 @@ def _set_or_check_java_home():
jvmpath = jvmpath.replace("\\bin\\bin\\server\\jvm.dll", "\\bin\\server\\jvm.dll")

logger.debug(f"Starting JVM from path {jvmpath}...")
jpype.startJVM(
jvmArgs = [
"-ea",
"--illegal-access=deny",
ignoreUnrecognized=True,
convertStrings=False,
jvmpath=jvmpath,
]

if "DASK_SQL_JVM_DEBUG_ENABLED" in os.environ: # pragma: no cover
logger.debug(
"Remote JVM debugging enabled. Application will wait for remote debugger to attach"
)
# Must be the first argument in the JVM args
jvmArgs.insert(
0, "-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=8000"
)

logger.debug(f"Starting JVM from path {jvmpath}...")
jpype.startJVM(
*jvmArgs, ignoreUnrecognized=True, convertStrings=False, jvmpath=jvmpath,
)

logger.debug("...having started JVM")


Expand Down