Skip to content

Added getContext() method to DaskPlanner to ensure that CalciteConfigC… #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
galipremsagar merged 1 commit into from
Jan 10, 2022
Merged

Added getContext() method to DaskPlanner to ensure that CalciteConfigC… #362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions planner/src/main/java/com/dask/sql/application/DaskPlanner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
import com.dask.sql.rules.DaskValuesRule;
import com.dask.sql.rules.DaskWindowRule;

import org.apache.calcite.config.CalciteConnectionConfig;
import org.apache.calcite.config.CalciteConnectionProperty;
import org.apache.calcite.plan.Context;
import org.apache.calcite.plan.Contexts;
import org.apache.calcite.plan.ConventionTraitDef;
import org.apache.calcite.plan.volcano.VolcanoPlanner;
import org.apache.calcite.rel.rules.CoreRules;
Expand All @@ -26,6 +30,9 @@
* as the null executor.
*/
public class DaskPlanner extends VolcanoPlanner {

private final Context defaultContext;

public DaskPlanner() {
// Allow transformation between logical and dask nodes
addRule(DaskAggregateRule.INSTANCE);
Expand Down Expand Up @@ -73,5 +80,13 @@ public DaskPlanner() {

// We do not want to execute any SQL
setExecutor(null);

// Use our defined type system and create a default CalciteConfigContext
defaultContext = Contexts.of(CalciteConnectionConfig.DEFAULT.set(
CalciteConnectionProperty.TYPE_SYSTEM, "com.dask.sql.application.DaskSqlDialect#DASKSQL_TYPE_SYSTEM"));
}

public Context getContext() {
return defaultContext;
}
}
12 changes: 12 additions & 0 deletions tests/integration/test_filter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,3 +68,15 @@ def test_string_filter(c, string_table):
assert_frame_equal(
return_df, string_table.head(1),
)


def test_filter_datetime(c):
df = pd.DataFrame({"year": [2015, 2016], "month": [2, 3], "day": [4, 5]})

df["dt"] = pd.to_datetime(df)

c.create_table("datetime_test", df)
actual_df = c.sql("select * from datetime_test where year(dt) < 2016").compute()
expected_df = df[df["year"] < 2016]

assert_frame_equal(expected_df, actual_df)