Skip to content

Conversation

@charlesbluca
Copy link
Collaborator

With ascending and na_position support now working for both Dask and Dask-cuDF, we can now use the fast apply_sort codepath for:

  • All single column sorts (CPU and GPU)
  • Multi-column sorts where sort_ascending and sort_null_first are homogeneous lists (GPU only)

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2021

Codecov Report

Merging #337 (967eafc) into main (96524ee) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
+ Coverage   95.69%   95.76%   +0.07%     
==========================================
  Files          65       65              
  Lines        2854     2856       +2     
  Branches      534      534              
==========================================
+ Hits         2731     2735       +4     
+ Misses         75       73       -2     
  Partials       48       48              
Impacted Files Coverage Δ
dask_sql/physical/utils/sort.py 90.62% <100.00%> (+7.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96524ee...967eafc. Read the comment docs.

@charlesbluca charlesbluca merged commit 3ac4136 into dask-contrib:main Dec 1, 2021
@charlesbluca charlesbluca deleted the update-fast-sort-conditions branch January 19, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants