Skip to content

Generalize table check in _get_tables_from_stack #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charlesbluca merged 1 commit into from
Nov 29, 2021
Merged

Generalize table check in _get_tables_from_stack #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dask_sql/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -882,7 +882,7 @@ def _get_tables_from_stack(self):
for var_name, variable in frame_info.frame.f_locals.items():
if var_name.startswith("_"):
continue
if not isinstance(variable, (pd.DataFrame, dd.DataFrame)):
if not dd.utils.is_dataframe_like(variable):
continue

# only set them if not defined in an inner context
Expand Down
14 changes: 1 addition & 13 deletions tests/unit/test_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,19 +168,7 @@ def assert_correct_output(gpu):


@pytest.mark.parametrize(
"gpu",
[
False,
pytest.param(
True,
marks=(
pytest.mark.gpu,
pytest.mark.xfail(
reason="GPU tables aren't picked up by _get_tables_from_stack"
),
),
),
],
"gpu", [False, pytest.param(True, marks=pytest.mark.gpu),],
)
def test_tables_from_stack(gpu):
c = Context()
Expand Down