Skip to content

Conversation

@charlesbluca
Copy link
Collaborator

Duplicate of #273, which was merged in before some groupby split_out tests could be resolved


@pytest.mark.gpu
@pytest.mark.parametrize("split_every,expected_keys", [(2, 91), (3, 85), (4, 81)])
def test_groupby_split_every_gpu(c, split_every, expected_keys):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we are able to access dask-cudf's groupby agg codepath, the task graph size varies depending on if we use GPU or not. There could be a clean way to parametrize this all into one test, but I opted for this for now to make the difference more clear.

In general, is there a way we can verify that split_every is working that doesn't depend on checking the task graph? Asking because now upstream changes in dask-cudf can break this test.

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2021

Codecov Report

Merging #326 (393f11c) into main (a3fc92d) will decrease coverage by 0.06%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
- Coverage   95.80%   95.74%   -0.07%     
==========================================
  Files          65       65              
  Lines        2834     2841       +7     
  Branches      426      429       +3     
==========================================
+ Hits         2715     2720       +5     
- Misses         74       75       +1     
- Partials       45       46       +1     
Impacted Files Coverage Δ
dask_sql/physical/rel/logical/aggregate.py 94.80% <85.71%> (-1.12%) ⬇️
dask_sql/physical/utils/groupby.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3fc92d...393f11c. Read the comment docs.

@charlesbluca charlesbluca merged commit 0c05787 into dask-contrib:main Nov 29, 2021
@charlesbluca charlesbluca deleted the simplify-groupby-agg branch January 19, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants