Skip to content

Conversation

@charlesbluca
Copy link
Collaborator

Some changes in dask 2021.11.0 caused breakage in dask-ml and consequently for our CREATE MODEL statements. This was fixed in dask/dask-ml#878 and now a new version of dask-ml is released which should resolve these failures. This will allow us to release with dask>=2021.10.0.

This PR bumps our dask-ml dependency and removes the xfail from the previously failing tests.

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2021

Codecov Report

Merging #322 (4db5b26) into main (fa7917a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #322   +/-   ##
=======================================
  Coverage   95.83%   95.83%           
=======================================
  Files          65       65           
  Lines        2810     2810           
  Branches      421      421           
=======================================
  Hits         2693     2693           
  Misses         74       74           
  Partials       43       43           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa7917a...4db5b26. Read the comment docs.

@charlesbluca charlesbluca merged commit 4223529 into dask-contrib:main Nov 17, 2021
@charlesbluca charlesbluca deleted the un-xfail-ml-test branch January 19, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants