-
Notifications
You must be signed in to change notification settings - Fork 72
Ignore case for queries in the parser configuration #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #316 +/- ##
==========================================
+ Coverage 95.69% 95.70% +0.01%
==========================================
Files 65 65
Lines 2854 2864 +10
Branches 534 536 +2
==========================================
+ Hits 2731 2741 +10
+ Misses 75 74 -1
- Partials 48 49 +1
Continue to review full report at Codecov.
|
|
One of the tests timed out. Running again. rerun tests |
|
Do you think that this could use the config options in #286 to expose this as something that can be exposed from the python layer to the java layer. Config options doesn't do this today but other parts of the code such as |
…ase sensitive queries
Sure, I just made the needed changes for that to happen. I just hard coded it to |
dask_sql/context.py
Outdated
| # Now create a relational algebra from that | ||
| generator_builder = RelationalAlgebraGeneratorBuilder(self.schema_name) | ||
| ignore_case = self.schema[self.schema_name].config.get_config_by_prefix( | ||
| "dask.sql.identifier.ignore_case" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am following existing logic here using magic strings but think we should likely move all of the configuration keys to mappings.py and add further documentation in a subsequent PR. I am happy to make that PR as well once this one merges. Would prefer to not make that change in this PR since that change effects other codebase areas as well.
|
rerun tests |
|
@charlesbluca not sure what is up with CI but seems like everything passed?? |
|
Looks like gpuCI got hung up on the Docker image pull and timed out; there was an issue opened about this recently in Dask: dask/dask#8465 rerun tests |
charlesbluca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work here @jdye64 😄 just one last comment:
|
rerun tests |
1 similar comment
|
rerun tests |
charlesbluca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work here @jdye64! Think the gpuCI failures yesterday may have been related to the AWS outage
This PR modifies the parser configuration to ensure that case does not matter across queries. This closes #315