Add handling for cuDF-backed tables in dask-sql-server
#312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randerzander
approved these changes
Nov 15, 2021
Collaborator
randerzander
left a comment
randerzander
left a comment
There was a problem hiding this comment.
In my poking at this months back, this is exactly what I ended up trying that worked.
I looked into the Presto client docs a bit, but couldn't find much in the way of supported result formats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should unblock failures when serving cuDF-backed tables using
dask-sql-server, but is not really ideal as it forces a host synchronization whenever we need to return a query result; a more ideal long term solution would be to explore server options that allow us to return results per-column instead of per-row (i.e. iterating over columns instead of rows, which can't be done in cuDF).cc @bryevdv this should resolve the failures we discussed and allow for some deeper exploration of Superset
xref #310