Use string separator in nightly version string #295
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some RAPIDS folk have noticed that dask-sql nightly versions include the date of their publishing:
This is an issue because it means you can't install nightlies of a specific minor version; for example:
This PR adds a string separator between the package version and publishing date, which should allow
conda install -c dask/label/dev dask-sql=0.4.0to work.Another potential solution I considered is to make a new pre-release tag with a string appended, e.g.
0.4.1a. This would achieve the same result as this PR, but I feel that it will be awkward naming pre-release tags when we eventually move over to CalVer (as we don't have a scheduled release cycle to go by).cc @jakirkham