Skip to content

Conversation

@charlesbluca
Copy link
Collaborator

Some RAPIDS folk have noticed that dask-sql nightly versions include the date of their publishing:

$ conda search --override-channel -c dask/label/dev dask-sql=0.4.0211102
Loading channels: done
# Name                       Version           Build  Channel             
dask-sql                 0.4.0211102 py38_g77f1d87_1  dask/label/dev

This is an issue because it means you can't install nightlies of a specific minor version; for example:

$ conda search --override-channel -c dask/label/dev dask-sql=0.4.0
No match found for: dask-sql=0.4.0. Search: *dask-sql*=0.4.0

PackagesNotFoundError: The following packages are not available from current channels:

  - dask-sql=0.4.0

This PR adds a string separator between the package version and publishing date, which should allow conda install -c dask/label/dev dask-sql=0.4.0 to work.

Another potential solution I considered is to make a new pre-release tag with a string appended, e.g. 0.4.1a. This would achieve the same result as this PR, but I feel that it will be awkward naming pre-release tags when we eventually move over to CalVer (as we don't have a scheduled release cycle to go by).

cc @jakirkham

@jakirkham
Copy link
Contributor

How do we want to handle the existing packages that don't have this? Leave them? Delete them (now possible that we cut a release)? Something else?

@charlesbluca
Copy link
Collaborator Author

charlesbluca commented Nov 3, 2021

I'm not sure if we have any use for the 0.3.9 nightlies at the moment (maybe @randerzander can speak to this?), but my preference would be to leave them just in case we need to compare a current nightly to one prior to the 0.4.0 release. That being said, it might be good to follow up on the Dask/Distributed nightlies issue to see if other maintainers have a preference here

That being said, I do think we should delete the single 0.4.0 nightly with this issue, to avoid conflict with future 0.4.0 nightlies.

@ajschmidt8
Copy link

I'm not sure if we have any use for the 0.3.9 nightlies at the moment (maybe @randerzander can speak to this?), but my preference would be to leave them just in case we need to compare a current nightly to one prior to the 0.4.0 release. That being said, it might be good to follow up on the Dask/Distributed nightlies issue to see if other maintainers have a preference here

That being said, I do think we should delete the single 0.4.0 nightly with this issue, to avoid conflict with future 0.4.0 nightlies.

Agree! Deleting the existing, single 0.4.0 sounds reasonable.

@randerzander
Copy link
Collaborator

I'm not sure if we have any use for the 0.3.9 nightlies at the moment (maybe @randerzander can speak to this?), but my preference would be to leave them just in case we need to compare a current nightly to one prior to the 0.4.0 release. That being said, it might be good to follow up on the Dask/Distributed nightlies issue to see if other maintainers have a preference here

That being said, I do think we should delete the single 0.4.0 nightly with this issue, to avoid conflict with future 0.4.0 nightlies.

I don't have an opinion on keeping the 0.3.9 nightlies.

@charlesbluca charlesbluca merged commit 4fa60fb into main Nov 3, 2021
@charlesbluca charlesbluca deleted the fix-nightly-version-suffix branch November 3, 2021 19:57
@jakirkham
Copy link
Contributor

That being said, I do think we should delete the single 0.4.0 nightly with this issue, to avoid conflict with future 0.4.0 nightlies.

Have deleted it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants