Skip to content

Prevent JVM Segfault #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charlesbluca merged 13 commits into from
Nov 9, 2021
Merged

Prevent JVM Segfault #294

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f703601
testing import order of java
jdye64 Nov 3, 2021
7d57639
import dask_cuda before any dask_sql import
jdye64 Nov 3, 2021
8324c56
try import for dask_cuda
jdye64 Nov 3, 2021
369d261
try import and noqa for unused import
jdye64 Nov 3, 2021
74a763a
fix simple syntax mistake
jdye64 Nov 3, 2021
67d4609
formatting issues
jdye64 Nov 3, 2021
ee5162f
testing for segfaults
jdye64 Nov 4, 2021
e9783b1
more testing
jdye64 Nov 4, 2021
5f93659
replace fix
jdye64 Nov 4, 2021
1ba9a26
noqa F401
jdye64 Nov 4, 2021
0dc2aa3
address review comments
jdye64 Nov 8, 2021
b104dff
change ordering
jdye64 Nov 8, 2021
0793b27
Merge remote-tracking branch 'upstream/main' into segfault_fix
jdye64 Nov 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions dask_sql/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,13 @@
from dask_sql.physical.rex import RexConverter, core
from dask_sql.utils import ParsingException

# try:
# import dask_cuda # noqa: F401
# except ImportError: # pragma: no cover
# pass
#


if TYPE_CHECKING:
from dask_sql.java import org

Expand Down
10 changes: 10 additions & 0 deletions tests/integration/fixtures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,16 @@
except ImportError:
cudf = None

try:
import dask_cudf
except ImportError:
dask_cudf = None

try:
from dask_cuda import LocalCUDACluster # noqa: F401
except ImportError:
dask_cuda = None


@pytest.fixture()
def timeseries_df(c):
Expand Down