[Review] Update readme and docstrings to indicate GPU support #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #292 +/- ##
=======================================
Coverage 95.99% 95.99%
=======================================
Files 64 64
Lines 2797 2798 +1
Branches 421 421
=======================================
+ Hits 2685 2686 +1
Misses 71 71
Partials 41 41
Continue to review full report at Codecov.
|
charlesbluca
reviewed
Nov 3, 2021
Collaborator
charlesbluca
left a comment
charlesbluca
left a comment
There was a problem hiding this comment.
This looks good - I think it would be good to follow up these references to GPU support with a section in the docs/readme with more detail on the requirements/risks (essentially that dask-cudf nightlies are required and that this is still experimental and prone to some failures).
charlesbluca
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates readme and docs to indicate that dask-sql supports gpus as well.
Fixes #291