Skip to content

Conversation

@brandon-b-miller
Copy link
Contributor

UDFs that call apply currently trigger a dask warning since the return type is not packed into the meta that the final apply call uses. This PR passes the original return type passed by the user into apply to prevent the warning.

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2021

Codecov Report

Merging #275 (37d66fc) into main (b42db23) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #275   +/-   ##
=======================================
  Coverage   95.81%   95.82%           
=======================================
  Files          64       64           
  Lines        2799     2800    +1     
  Branches      424      424           
=======================================
+ Hits         2682     2683    +1     
  Misses         75       75           
  Partials       42       42           
Impacted Files Coverage Δ
dask_sql/context.py 99.09% <100.00%> (ø)
dask_sql/datacontainer.py 94.11% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b42db23...37d66fc. Read the comment docs.

@quasiben
Copy link
Contributor

Thanks @brandon-b-miller

@quasiben quasiben merged commit 8d69184 into dask-contrib:main Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants