Add support for GPU table creation in dask / location plugins #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #251 +/- ##
==========================================
- Coverage 95.74% 95.69% -0.05%
==========================================
Files 65 65
Lines 2841 2855 +14
Branches 429 432 +3
==========================================
+ Hits 2720 2732 +12
Misses 75 75
- Partials 46 48 +2
Continue to review full report at Codecov.
|
charlesbluca
commented
Nov 4, 2021
|
|
||
| for plugin in [DaskInputPlugin(), PandasLikeInputPlugin()]: | ||
| if plugin.is_correct_input(df, table_name, format, **kwargs): | ||
| return plugin.to_dc(df, table_name, format, gpu, **kwargs) |
Collaborator
Author
There was a problem hiding this comment.
This seems like the most sensible way to handle published datasets without duplicating code, but I am not sure if there's a cleaner way this could be done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to stop xfailing some of the GPU tests for table creation