Skip to content

Conversation

@charlesbluca
Copy link
Collaborator

We are seeing an additional failure on test_deprecation_warning when running the GPU-enabled test on gpuCI - not sure where this is coming from, investigating on this PR

@charlesbluca charlesbluca mentioned this pull request Oct 6, 2021
@charlesbluca
Copy link
Collaborator Author

charlesbluca commented Oct 6, 2021

So it looks like we're also getting a

ResourceWarning('unclosed event loop <_UnixSelectorEventLoop running=False closed=False debug=False>')

here, though I'm not sure what the cause of it is. A workaround for this would be to change the simplefilter we're using to only look out for DeprecationWarnings here, though I'm not sure if this warning should be cause for concern.

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2021

Codecov Report

Merging #248 (4961917) into main (3d4296b) will increase coverage by 100.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           main      #248        +/-   ##
===========================================
+ Coverage      0   100.00%   +100.00%     
===========================================
  Files         0        64        +64     
  Lines         0      2590      +2590     
  Branches      0       361       +361     
===========================================
+ Hits          0      2590      +2590     
Impacted Files Coverage Δ
dask_sql/physical/rel/logical/values.py 100.00% <0.00%> (ø)
dask_sql/physical/rel/custom/analyze.py 100.00% <0.00%> (ø)
dask_sql/physical/rex/__init__.py 100.00% <0.00%> (ø)
dask_sql/physical/rel/logical/project.py 100.00% <0.00%> (ø)
dask_sql/physical/rel/custom/drop_table.py 100.00% <0.00%> (ø)
dask_sql/physical/rel/custom/tables.py 100.00% <0.00%> (ø)
dask_sql/physical/rex/core/input_ref.py 100.00% <0.00%> (ø)
dask_sql/physical/rel/custom/drop_schema.py 100.00% <0.00%> (ø)
dask_sql/physical/rel/custom/export_model.py 100.00% <0.00%> (ø)
dask_sql/physical/rel/logical/join.py 100.00% <0.00%> (ø)
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d4296b...4961917. Read the comment docs.

@charlesbluca
Copy link
Collaborator Author

rerun tests

@charlesbluca charlesbluca merged commit 54d72cd into dask-contrib:main Oct 6, 2021
@charlesbluca charlesbluca deleted the fix-deprecation-test branch January 19, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants