[REVIEW] Fix dynamic_partition_pruning to handle a single Parquet file
#1280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahyurick
requested review from
ayushdg,
charlesbluca,
galipremsagar and
jdye64
as code owners
Collaborator
Author
|
Hi @charlesbluca it looks like the gpuCI failure is unrelated? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1280 +/- ##
==========================================
- Coverage 85.54% 85.07% -0.47%
==========================================
Files 77 77
Lines 4261 4261
Branches 795 795
==========================================
- Hits 3645 3625 -20
- Misses 447 462 +15
- Partials 169 174 +5 ☔ View full report in Codecov by Sentry. |
sarahyurick
changed the title
dynamic_partition_pruning to handle a single Parquet filedynamic_partition_pruning to handle a single Parquet file
Collaborator
Author
|
Hi @charlesbluca LMK what you think of this. |
Collaborator
charlesbluca
left a comment
charlesbluca
left a comment
There was a problem hiding this comment.
Thanks @sarahyurick! Can verify locally that this resolved #1268; is there a trivial way we can add a test around this behavior?
Collaborator
|
rerun tests |
charlesbluca
approved these changes
Jan 31, 2024
Collaborator
charlesbluca
left a comment
charlesbluca
left a comment
There was a problem hiding this comment.
Thanks @sarahyurick!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1268