Skip to content

Fix test_cmd for upstream testing #1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charlesbluca merged 4 commits into from
Aug 7, 2023
Merged

Fix test_cmd for upstream testing #1212

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b96aef2
unpin dask/distributed for development
ayushdg Aug 3, 2023
f85d18b
Merge branch 'main' into unpin-dask-distributed
ayushdg Aug 3, 2023
0336745
Temporarily switch port for cmd test to non dashboard port
ayushdg Aug 3, 2023
3699529
Merge branch 'main' into fix-upstream-test-cmd
ayushdg Aug 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tests/integration/test_cmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,13 +106,14 @@ def test_meta_commands(c, client, capsys):
captured = capsys.readouterr()
assert "Schema not_exists not available\n" == captured.out

# FIXME: Revert to 8787 once https://github.com/dask/distributed/issues/8071 is fixed
with pytest.raises(
OSError,
match="Timed out .* to tcp://localhost:8787 after 5 s",
match="Timed out .* to tcp://localhost:8788 after 5 s",
):
with dask_config.set({"distributed.comm.timeouts.connect": 5}):
client = _meta_commands("\\dsc localhost:8787", context=c, client=client)
assert client.scheduler.__dict__["addr"] == "localhost:8787"
client = _meta_commands("\\dsc localhost:8788", context=c, client=client)
assert client.scheduler.__dict__["addr"] == "localhost:8788"


def test_connection_info(c, client, capsys):
Expand Down