Skip to content

Print exception origin in crash messages #3653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
UdjinM6 merged 2 commits into from
Aug 14, 2020
Merged

Print exception origin in crash messages #3653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
431ecbf
Print exception origin in crash messages
UdjinM6 Aug 2, 2020
0b49497
Update src/util.cpp
UdjinM6 Aug 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/util.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,14 +576,9 @@ std::string HelpMessageOpt(const std::string &option, const std::string &message
std::string("\n\n");
}

static std::string FormatException(const std::exception_ptr pex, const char* pszThread)
void PrintExceptionContinue(const std::exception_ptr pex, const char* pszExceptionOrigin)
{
return GetPrettyExceptionStr(pex);
}

void PrintExceptionContinue(const std::exception_ptr pex, const char* pszThread)
{
std::string message = FormatException(pex, pszThread);
std::string message = strprintf("\"%s\" raised an exception\n%s", pszExceptionOrigin, GetPrettyExceptionStr(pex));
LogPrintf("\n\n************************\n%s\n", message);
fprintf(stderr, "\n\n************************\n%s\n", message.c_str());
}
Expand Down
2 changes: 1 addition & 1 deletion src/util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ bool error(const char* fmt, const Args&... args)
return false;
}

void PrintExceptionContinue(const std::exception_ptr pex, const char* pszThread);
void PrintExceptionContinue(const std::exception_ptr pex, const char* pszExceptionOrigin);
void FileCommit(FILE *file);
bool TruncateFile(FILE *file, unsigned int length);
int RaiseFileDescriptorLimit(int nMinFD);
Expand Down