rpc: update help text for BLS operator key arguments #3628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I would like to mirror docs.dash.org/en/stable/masternodes/maintenance.html#proupservtx by adding the specific term "BLS" to the rpc help menu to differentiate this is not a dash address key like the other ownerkey votingkey. We had this changed on the docs site to help clarify for people who were missing the point this was the operator BLS key.
|
Makes sense 👍 Could you pls also update other strings while at it to ensure consistency? --- a/src/rpc/rpcevo.cpp
+++ b/src/rpc/rpcevo.cpp
@@ -61,8 +61,8 @@ std::string GetHelpString(int nParamNum, std::string strParamName)
" Must be unique on the network. Can be set to 0, which will require a ProUpServTx afterwards.\n"
},
{"operatorKey",
- "%d. \"operatorKey\" (string, required) The operator private key belonging to the\n"
- " registered operator public key.\n"
+ "%d. \"operatorKey\" (string, required) The operator BLS private key asociated with the\n"
+ " registered operator BLS public key.\n"
},
{"operatorPayoutAddress",
"%d. \"operatorPayoutAddress\" (string, optional) The address used for operator reward payments.\n"
@@ -70,12 +70,12 @@ std::string GetHelpString(int nParamNum, std::string strParamName)
" If set to an empty string, the currently active payout address is reused.\n"
},
{"operatorPubKey_register",
- "%d. \"operatorPubKey\" (string, required) The operator BLS public key. The private key does not have to be known.\n"
- " It has to match the private key which is later used when operating the masternode.\n"
+ "%d. \"operatorPubKey\" (string, required) The operator BLS public key. The operator BLS private key does not have to be known.\n"
+ " It has to match the operator BLS private key which is later used when operating the masternode.\n"
},
{"operatorPubKey_update",
- "%d. \"operatorPubKey\" (string, required) The operator BLS public key. The private key does not have to be known.\n"
- " It has to match the private key which is later used when operating the masternode.\n"
+ "%d. \"operatorPubKey\" (string, required) The operator BLS public key. The operator BLS private key does not have to be known.\n"
+ " It has to match the operator BLS private key which is later used when operating the masternode.\n"
" If set to an empty string, the currently active operator BLS public key is reused.\n"
},
{"operatorReward", |
UdjinM6
changed the title
PastaPastaPasta
changed the title
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Aug 23, 2020
* Update rpcevo.cpp I would like to mirror docs.dash.org/en/stable/masternodes/maintenance.html#proupservtx by adding the specific term "BLS" to the rpc help menu to differentiate this is not a dash address key like the other ownerkey votingkey. We had this changed on the docs site to help clarify for people who were missing the point this was the operator BLS key. * Update rpcevo.cpp
Member
|
backported in #3670 |
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Jun 17, 2023
* Update rpcevo.cpp I would like to mirror docs.dash.org/en/stable/masternodes/maintenance.html#proupservtx by adding the specific term "BLS" to the rpc help menu to differentiate this is not a dash address key like the other ownerkey votingkey. We had this changed on the docs site to help clarify for people who were missing the point this was the operator BLS key. * Update rpcevo.cpp
gades
pushed a commit
to piratecash/pirate
that referenced
this pull request
Dec 9, 2023
* Update rpcevo.cpp I would like to mirror docs.dash.org/en/stable/masternodes/maintenance.html#proupservtx by adding the specific term "BLS" to the rpc help menu to differentiate this is not a dash address key like the other ownerkey votingkey. We had this changed on the docs site to help clarify for people who were missing the point this was the operator BLS key. * Update rpcevo.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please mirror docs.dash.org/en/stable/masternodes/maintenance.html#proupservtx by adding the specific term "BLS" to the rpc help menu to differentiate this is not a dash address key like the other ownerkey votingkey. We had this changed on the docs site to help clarify for people who were missing the point this was the operator BLS key. Thanks