privatesend: Increase max participants to 20 #3610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pasta <[email protected]>
Signed-off-by: pasta <[email protected]>
Signed-off-by: pasta <[email protected]>
Signed-off-by: pasta <[email protected]>
|
Is there any reason to not increase it even more if you say the theoretical maximum should be around 60? |
Member
Author
|
The more participants you have I assume the more problems you might have. That'll require more connection slots etc. It might be fine to do so, but imo would require more research and I don't expect that this will be getting maxed out on mainnet at this point so no trouble capping it at 20 |
|
utACK, At this point i can't attest that this doesn't break anything in the PS process but the min/max increase itself with the spork looks good to me. |
xdustinface
approved these changes
Jul 16, 2020
PastaPastaPasta
changed the title
PastaPastaPasta
added a commit
to PastaPastaPasta/dash
that referenced
this pull request
Aug 23, 2020
* Add spork to change max mixing participants to 20 Signed-off-by: pasta <[email protected]> * Also change min participants on devnet/testnet Signed-off-by: pasta <[email protected]> * adjust formatting Signed-off-by: pasta <[email protected]> * add nPoolNewMinParticipants under regtest Signed-off-by: pasta <[email protected]>
Member
Author
|
backported in #3670 |
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Apr 18, 2022
* Add spork to change max mixing participants to 20 Signed-off-by: pasta <[email protected]> * Also change min participants on devnet/testnet Signed-off-by: pasta <[email protected]> * adjust formatting Signed-off-by: pasta <[email protected]> * add nPoolNewMinParticipants under regtest Signed-off-by: pasta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new spork which will change the maximum number of participants from 5 to 20 (the theoretical limit based on tx size limit should be around 60). This should increase the general privacy of privatesend when there is sufficient liquidity on the network. In the case that there is insufficient liquidity, privacy is the same as it is today, with a minimum number of participants of 3 (actually 2 on devnet/testnet once this spork is activated to make it easier to test mixing).
If there's a better way to do this, let me know