Skip to content

Update goblin to 0.0.10 #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
flanfly merged 1 commit into from
Jul 30, 2017
Merged

Update goblin to 0.0.10 #314

flanfly merged 1 commit into from
Jul 30, 2017

Conversation

@philipc
Copy link
Contributor

@philipc philipc commented Jul 30, 2017

I need this to avoid a link error when using panopticon in another project that uses goblin 0.0.10.

@coveralls
Copy link

coveralls commented Jul 30, 2017

Coverage Status

Coverage increased (+0.3%) to 59.749% when pulling 665f8fb on philipc:goblin into dd48efc on das-labor:master.

m4b
m4b approved these changes Jul 30, 2017
View reviewed changes
Copy link
Collaborator

@m4b m4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cc @flanfly

P.S. Just curious what exactly do you mean that you received linker errors ? The goblin backend shouldn't be exposed at all in panopticon so I'd be surprised/worried if it caused issues

@philipc
Copy link
Contributor Author

philipc commented Jul 30, 2017

Multiple definitions of wow_so_meta_doge_symbol. I guess the #[no_mangle] on it is the problem.

@m4b
Copy link
Collaborator

m4b commented Jul 30, 2017

😭 heh what kind of idiot names a symbol that ? 😆

I'll see if I can remove it for future versions, thanks for the report !

m4b added a commit to m4b/goblin that referenced this pull request Jul 30, 2017
@m4b
archive: remove wow_so_meta_doge_symbol (we test member_of_symbol els…
9cbb08e 
…ewhere), ref das-labor/panopticon#314
@flanfly flanfly merged commit 6b1aad5 into das-labor:master Jul 30, 2017
@flanfly
Copy link
Member

flanfly commented Jul 30, 2017

👍

@philipc philipc deleted the goblin branch July 31, 2017 04:47
@m4b m4b mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m4b m4b m4b approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@philipc @coveralls @m4b @flanfly