Skip to content

Lazy payout#346

Merged
hackfisher merged 18 commits intodarwinia-network:developfrom
aurexav:lazy-payout
Mar 17, 2020
Merged

Lazy payout#346
hackfisher merged 18 commits intodarwinia-network:developfrom
aurexav:lazy-payout

Conversation

@aurexav
Copy link
Copy Markdown
Member

@aurexav aurexav commented Mar 14, 2020

No description provided.

@aurexav
Copy link
Copy Markdown
Member Author

aurexav commented Mar 14, 2020

@clearloop Could you fix the tests? Base on 75116bd8c45c7e46a9b8eed9cb29ee4256ed631b.

@aurexav aurexav mentioned this pull request Mar 14, 2020
Closed
@aurexav aurexav requested a review from hackfisher March 14, 2020 12:10
@clearloop
Copy link
Copy Markdown
Contributor

clearloop commented Mar 14, 2020 •
edited
Loading

@AurevoirXavier Ok...

@aurexav aurexav linked an issue Mar 14, 2020 that may be closed by this pull request
Staking module currently are using for loop to pay dividends. #55
Closed
@hackfisher
Copy link
Copy Markdown
Contributor

hackfisher commented Mar 14, 2020 •
edited
Loading

@clearloop Could you fix the tests? Base on 75116bd8c45c7e46a9b8eed9cb29ee4256ed631b.

@AurevoirXavier @clearloop
Github seems to support collaborating with others by committing to a pull request, might need some permission config from PR's owner.

https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/committing-changes-to-a-pull-request-branch-created-from-a-fork

BTW, the CI build failed.

@clearloop
Copy link
Copy Markdown
Contributor

clearloop commented Mar 14, 2020

Github seems to support commit to a pull request, might need some permission config from PR's owner.

Ok, I'll fork @AurevoirXavier 's branch

@aurexav
Copy link
Copy Markdown
Member Author

aurexav commented Mar 14, 2020 •
edited
Loading

@AurevoirXavier @clearloop
Github seems to support collaborating with others by committing to a pull request, might need some permission config from PR's owner.

help.github.com/en/github/collaborating-with-issues-and-pull-requests/committing-changes-to-a-pull-request-branch-created-from-a-fork

Example: #170

BTW, the CI build failed.

#347 (comment)

@clearloop
Copy link
Copy Markdown
Contributor

clearloop commented Mar 14, 2020 •
edited
Loading

Example: #170

Steps

  • fix substrate_tests
  • patch docs
  • fix darwinia_tests
  • fix reward
  • patch docs

clearloop
clearloop reviewed Mar 15, 2020
View reviewed changes
@aurexav
Copy link
Copy Markdown
Member Author

aurexav commented Mar 16, 2020 •
edited
Loading

I'll finish the rest of the tests.

Move to #351, due to some questions.

@hackfisher hackfisher merged commit e164cf0 into darwinia-network:develop Mar 17, 2020
@aurexav aurexav deleted the lazy-payout branch March 17, 2020 08:32
@clearloop clearloop mentioned this pull request Mar 17, 2020
Closed
@aurexav aurexav mentioned this pull request Mar 20, 2020
Merged
boundless-forest added a commit that referenced this pull request Aug 1, 2023
@boundless-forest
Tx gas should never larger than block limit (#346)
63c4a77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hackfisher hackfisher hackfisher approved these changes

+1 more reviewer

@clearloop clearloop clearloop left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Staking module currently are using for loop to pay dividends.

3 participants

@aurexav @clearloop @hackfisher