Skip to content
This repository was archived by the owner on Mar 13, 2023. It is now read-only.

Code clean#1450

Merged
hackfisher merged 4 commits intomainfrom
bear-fix-compile
Sep 26, 2022
Merged

Code clean#1450
hackfisher merged 4 commits intomainfrom
bear-fix-compile

Conversation

@boundless-forest
Copy link
Copy Markdown
Member

@boundless-forest boundless-forest commented Sep 23, 2022

Too many * make it hard to tell where a particular variable, trait, or const comes from. And it is hard to tell which is useless in the upstream repo. Related to darwinia-network/darwinia-messages-substrate#189

@boundless-forest boundless-forest marked this pull request as ready for review September 23, 2022 09:21
@aurexav
Copy link
Copy Markdown
Member

aurexav commented Sep 23, 2022

I think the upstream should not take care of how the downstream use(habits/styles) it.

@aurexav aurexav added the U-Housekeeping [Uncategorized] Some code cleaning works, which must not touch the logic label Sep 23, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 23, 2022

Commit cbce8c2

Pangolin

Check Runtime Version

Check Storage Prefix

Pangoro

Check Runtime Version

Check Storage Prefix

Commit 5b813ca

Pangolin

Check Runtime Version

Check Storage Prefix

Pangoro

Check Runtime Version

Check Storage Prefix

Commit 7a2b49b

Pangolin

Check Runtime Version

Check Storage Prefix

Pangoro

Check Runtime Version

Check Storage Prefix

Copy link
Copy Markdown
Contributor

@hackfisher hackfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hackfisher hackfisher merged commit 5622f5e into main Sep 26, 2022
@hackfisher hackfisher deleted the bear-fix-compile branch September 26, 2022 02:30
@aurexav
Copy link
Copy Markdown
Member

aurexav commented Sep 26, 2022

Need a companion for Darwinia.

@boundless-forest
Copy link
Copy Markdown
Member Author

Need a companion for Darwinia.

Do it together with other companions in the next Darwinia release?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

U-Housekeeping [Uncategorized] Some code cleaning works, which must not touch the logic

Projects

No open projects
Status: Need Companion

Development

Successfully merging this pull request may close these issues.

3 participants