Migrate injected client to package:web #2491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
derekxu16
force-pushed
the
migrate-client-to-package-web
branch
7 times, most recently
from
11040b5 to
210d303
Compare
derekxu16
force-pushed
the
migrate-client-to-package-web
branch
from
210d303 to
7a98931
Compare
bkonyi
approved these changes
Oct 7, 2024
derekxu16
force-pushed
the
migrate-client-to-package-web
branch
from
7a98931 to
b8d31a8
Compare
iinozemtsev
added a commit
to iinozemtsev/webdev
that referenced
this pull request
Nov 27, 2025
In dart-lang#2491, the reloader was changed to pass two arguments instead of an object with two fields into dartLibrary.reload. As a result, the javascript side couldn't find the promise in a field of the first argument and ignored the second argument. Usually it is fine, but this broke postponing main launch until the attached debugger can configure breakpoints. Again, this is not a big deal for interactive long-running apps, but if the main is fast and short (e.g. tests), this effectively prevents interactive debugging from an IDE.
iinozemtsev
added a commit
to iinozemtsev/webdev
that referenced
this pull request
Nov 27, 2025
In dart-lang#2491, the reloader was changed to pass two arguments instead of an object with two fields into dartLibrary.reload. As a result, the javascript side couldn't find the promise in a field of the first argument and ignored the second argument. Usually it is fine, but this broke postponing main launch until the attached debugger can configure breakpoints. Again, this is not a big deal for interactive long-running apps, but if the main is fast and short (e.g. tests), this effectively prevents interactive debugging from an IDE.
iinozemtsev
added a commit
that referenced
this pull request
Nov 27, 2025
In #2491, the reloader was changed to pass two arguments instead of an object with two fields into dartLibrary.reload. As a result, the javascript side couldn't find the promise in a field of the first argument and ignored the second argument. Usually it is fine, but this broke postponing main launch until the attached debugger can configure breakpoints. Again, this is not a big deal for interactive long-running apps, but if the main is fast and short (e.g. tests), this effectively prevents interactive debugging from an IDE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revival of #2306
Issue: #2338