-
Notifications
You must be signed in to change notification settings - Fork 742
Clarify how null safety relates to runtime errors in variables.md #6983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Replace overstatement about absence of all runtime errors with more precise language.
Summary of ChangesHello @matthew-a-thomas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the accuracy of the Dart language documentation by clarifying how null safety relates to runtime errors. It updates a section in Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request makes a valuable correction to the documentation, removing an overstatement about runtime errors in Dart. The new wording is more precise. I've added one suggestion to further refine the language to be even more explicit about the benefits of null safety's compile-time checks.
| In other languages, trying this could lead to a runtime error. | ||
| Dart's compiler prevents this error by prohibiting these actions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great clarification that removes the previous overstatement. To make the benefit of null safety even clearer, you could consider rephrasing to explicitly mention that this check happens at compile time. This would reinforce the point made just before the example.
| In other languages, trying this could lead to a runtime error. | |
| Dart's compiler prevents this error by prohibiting these actions. | |
| In other languages, trying this could lead to a runtime error. | |
| With null safety, Dart reports this potential error at compile time. |
Replace overstatement about absence of all runtime errors with more precise language.
Surely, Dart apps can cause runtime errors 🙃
Instead, the wonderful benefit of null safety is the reduction of this specific kind of runtime error.