[2.17] Document enhanced enums in the language tour and samples #4026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Conceptually this looks great! Adding @lrhn for a technical review. |
sfshaza2
approved these changes
May 7, 2022
Collaborator
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
Muah! (Aka, the chef who kisses her fingers for a perfect dish.) Here is some clarification for "which" vs "that": https://www.quickanddirtytips.com/education/grammar/which-versus-that-0
Please do apply the changes, but it looks great!!
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
lrhn
approved these changes
May 9, 2022
domesticmouse
approved these changes
May 11, 2022
Co-authored by: Brett Morgan <[email protected]>
parlough
force-pushed
the
feature/enhanced-enums
branch
from
62f8c92 to
bcbad14
Compare
|
Visit the preview URL for this PR (updated for commit bcbad14): https://dart-dev--pr4026-feature-enhanced-enu-sjg5f9zr.web.app (expires Wed, 18 May 2022 15:30:56 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents the new Enhanced enums feature along with some other adjustments and additions to enum documentation, primarily in the language tour. I tried to find a balance of documenting some features but not repeating too much from the various classes sections as there is a lot of overlap.
Beyond that, we did not document enums at all in the language samples. With enums now expanded functionality, this PR also introduces some enum samples there as well.
Staged:
Closes #3699
Note test failures are expected due to 2.17 not hitting stable yet.