Add failing test for pre-release and backtracking behavior #3038
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I have been spending a lot of time on a Rust port of pubgrub and stumbled upon a tricky case regarding handling of pre-releases and backtracking behavior. In particular, due to the creation of
NoVersionsincompatibilities potentially preventing the selection of a pre-release version after backtracking.So I've checked how pub handles this by adding a test and it seems that pub fails to solve dependencies in that situation. Here is the test I've added:
It consists of putting the solver on the wrong track by making it pick
a 1.1.0followed byb 1.0.0then realizing that there is no compatiblec. At that moment, it should backtrack and remember the wrong decision withNoVersionsincompatibilities. The issue is that it seems to create knowledge preventing it to pick theb 1.1.0-alphapre-release while it's a totally valid version after backtracking.What are your thoughts on this?