Skip to content

Conversation

@liamappelbe
Copy link
Contributor

@liamappelbe liamappelbe commented Sep 19, 2025

Add bindings for NSNull, and add support for it in the converter functions. ObjC has a null equivalent, nil, but you're not allowed to put nil in collections like NSArray for some reason. So in they added NSNull instead (very good null safety design, definitely not a hack 🙄). Fixes #2629

Also, fix #2627. NSMutableDictionary.of should return an NSMutableDictionary.

@github-actions
Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
objective_c Breaking 8.1.0 9.0.0-dev.0 9.0.0 ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources
objective_c _FinalizablePointer internal.dart::_ObjCReference::new::_finalizable

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

@coveralls
Copy link

coveralls commented Sep 19, 2025

Coverage Status

coverage: 82.297%. remained the same
when pulling a9c9fef on ns_null
into 4d1f149 on main.

@liamappelbe liamappelbe enabled auto-merge (squash) September 19, 2025 03:17
@liamappelbe liamappelbe merged commit e78967c into main Sep 19, 2025
34 checks passed
@liamappelbe liamappelbe deleted the ns_null branch September 19, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide access to NSNull in generated dart NSMutableDictionary.of() returns NSDictionary instead of NSMutableDictionary

3 participants