Skip to content

[native_toolchain_c] Rename assetName to assetId #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dcharkes merged 1 commit into from
Aug 8, 2023
Merged

[native_toolchain_c] Rename assetName to assetId #114

dcharkes merged 1 commit into from
Aug 8, 2023

Conversation

@dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Aug 7, 2023 •
edited
Loading

Bug #100.

  1. This PR: Roll rename into package:native_toolchain_c and rename param.
  2. Then publish native_toolchain_c.
  3. Then a PR that rolls both native_toolchain_c and native_assets_cli into native_assets_builder.

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

Package publishing

Package Version Status Publish tag (post-merge)
package:native_toolchain_c 0.2.0 ready to publish native_toolchain_c-v0.2.0
package:native_assets_builder 0.2.0-wip pre-release version (no publish necessary)
package:native_assets_cli 0.2.0 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

HosseinYousefi
HosseinYousefi approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@HosseinYousefi HosseinYousefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dcharkes dcharkes merged commit 9ee4689 into main Aug 8, 2023
@dcharkes dcharkes deleted the roll-asset-id branch August 8, 2023 08:30
HosseinYousefi pushed a commit that referenced this pull request Nov 16, 2023
@mahesh-hegde
[jnigen] Some summarizer improvements (#114)
269c96c
HosseinYousefi pushed a commit that referenced this pull request Nov 16, 2023
@mahesh-hegde
[jnigen] Some summarizer improvements (#114)
8680cf8
HosseinYousefi pushed a commit that referenced this pull request Nov 16, 2023
@dcharkes
[native_toolchain_c] Rename assetName to assetId (#114)
9e0b50c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HosseinYousefi HosseinYousefi HosseinYousefi approved these changes

@mkustermann mkustermann Awaiting requested review from mkustermann

Assignees

No one assigned

Labels

package:native_toolchain_c

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dcharkes @HosseinYousefi