Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkgs/cronet_http/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## 0.4.3-wip

* Fix invalid requests method.

## 0.4.2

* Require `package:jni >= 0.7.2` to remove a potential buffer overflow.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import 'dart:io';

import 'package:cronet_http/cronet_http.dart';
import 'package:http/http.dart';
import 'package:integration_test/integration_test.dart';
import 'package:test/test.dart';

Expand Down Expand Up @@ -92,6 +93,49 @@ void testInvalidConfigurations() {
});
}

void testMethods() {
group('methods', () {
late HttpServer server;
late String requestMethod;

setUp(() async {
server = (await HttpServer.bind('localhost', 0))
..listen((request) async {
await request.drain<void>();
requestMethod = request.method;
await request.response.close();
});
});
tearDown(() {
server.close();
});

test('methods', () async {
final engine = CronetEngine.build();
const methods = [
'GET',
'HEAD',
'POST',
'PUT',
'DELETE',
'CONNECT',
'OPTIONS',
'TRACE',
'PATCH',
'CUSTOM',
];
for (final method in methods) {
final request = Request(
method,
Uri.parse('http://localhost:${server.port}'),
);
await CronetClient.fromCronetEngine(engine).send(request);
expect(requestMethod, method);
}
});
});
}

void testUserAgent() {
group('userAgent', () {
late HttpServer server;
Expand Down Expand Up @@ -125,5 +169,6 @@ void main() {

testCache();
testInvalidConfigurations();
testMethods();
testUserAgent();
}
14 changes: 8 additions & 6 deletions pkgs/cronet_http/lib/src/cronet_client.dart
Original file line number Diff line number Diff line change
Expand Up @@ -312,12 +312,14 @@ class CronetClient extends BaseClient {
final responseCompleter = Completer<StreamedResponse>();
final engine = _engine!._engine;

final builder = engine.newUrlRequestBuilder(
request.url.toString().toJString(),
jb.UrlRequestCallbackProxy.new1(
_urlRequestCallbacks(request, responseCompleter)),
_executor,
);
final builder = engine
.newUrlRequestBuilder(
request.url.toString().toJString(),
jb.UrlRequestCallbackProxy.new1(
_urlRequestCallbacks(request, responseCompleter)),
_executor,
)
.setHttpMethod(request.method.toJString());

var headers = request.headers;
if (body.isNotEmpty &&
Expand Down