#4134. Add comments placement tests for operators#4213
Merged
szakarias merged 2 commits intodart-lang:mainfrom Feb 24, 2026
Merged
#4134. Add comments placement tests for operators#4213szakarias merged 2 commits intodart-lang:mainfrom
szakarias merged 2 commits intodart-lang:mainfrom
Conversation
szakarias
approved these changes
Feb 24, 2026
|
|
||
| @reflectiveTest | ||
| class PlacementTest extends Co19TestBase { | ||
| /// Check that doc comments in a class can be recognized before a user-defined |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Check that doc comments in a class can be recognized before a user-defined | |
| /// Check that doc comments in a class can be recognized before user-defined |
| Line 1'''); | ||
| } | ||
|
|
||
| /// Check that block-based doc comments in a class can be recognized before a |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Check that block-based doc comments in a class can be recognized before a | |
| /// Check that block-based doc comments in a class can be recognized before |
| expect(op2.documentation, 'Line 1'); | ||
| } | ||
|
|
||
| /// Check that doc comments in a mixin can be recognized before a user-defined |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Check that doc comments in a mixin can be recognized before a user-defined | |
| /// Check that doc comments in a mixin can be recognized before user-defined |
| } | ||
|
|
||
| /// Check that doc comments in a mixin can be recognized before a user-defined | ||
| /// operator. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// operator. | |
| /// operators. |
| Line 1'''); | ||
| } | ||
|
|
||
| /// Check that block-based doc comments in a mixin can be recognized before a |
Contributor
There was a problem hiding this comment.
Maybe just clean up all the commets and decide on singular or plural of "operator" in the descriptions.
Collaborator
Author
|
Thank you. All comments rewritten using plural. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.