Skip to content

Conversation

@Kim-SSi
Copy link
Contributor

@Kim-SSi Kim-SSi commented Nov 13, 2024

Update other NuGet Packages

The version in the project still needs to be checked or changed, I was unsure what format you wanted to follow.

@darinkes darinkes self-assigned this Nov 15, 2024
<PackageReference Include="SSH.NET" Version="[2023.0.1,)" />
<PackageReference Include="SshNet.Security.Cryptography" Version="[1.3.0]" />
<PackageReference Include="Konscious.Security.Cryptography.Argon2" Version="1.3.0"/>
<PackageReference Include="SSH.NET" Version="2024.2.0" />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this actually needed? The intention with "[2023.0.1,)" was to define everything from 2023.0.1 and above is fine.
No its limited to just this SSH.NET Version, or?

Copy link
Contributor Author

@Kim-SSi Kim-SSi Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should probably be the following due to the inclusion of BouncyCastle in 2024.2.0 being required to remove the remove dependency:

<PackageReference Include="SSH.NET" Version="[2024.2.0,)" />

Would You like me to correct the PR with this?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, right. SSH.NET now has BouncyCastle. Maybe we can get rid of the Konscious dependency and use this instead.
On the other hand, they are discussing wether to integrate PuttyKeyFiles upstream. So not sure if it's worth the effort.
See: sshnet/SSH.NET#1542 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting putty support upstream would be great.

I have updated the PR with the correct version string.
It would be great to get this released to hold over until getting putty support upstream is complete.

The currently released BC 2.4.0 does not contain Argon2 support yet. It is only in the pre-release 2.5.0.
Once that is released then Konscious.Security.Cryptography.Argon2 can be removed.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure, we will support this till upstream has an official release.
I will check it out this weekend and do the release stuff.

@darinkes darinkes merged commit c19921f into darinkes:main Dec 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants