Adding built in workflow versioning strategies with defaults#1707
Merged
WhitWaldo merged 5 commits intodapr:masterfrom Feb 12, 2026
Merged
Adding built in workflow versioning strategies with defaults#1707WhitWaldo merged 5 commits intodapr:masterfrom
WhitWaldo merged 5 commits intodapr:masterfrom
Conversation
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…test coverage Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…tions` if not provided Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…s and unit tests for each Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
This was referenced Mar 2, 2026
This was referenced Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rather than leave developers to have to create their own versioning strategies or copy the strategies out of the existing integration tests, it makes sense to bundle versioning strategies into the distributable package so they're readily available. In addition to having the strategies built-in, this PR also picks the
NumericVersionStrategyandMaxVersionSelectoras the defaults. They can be trivially overridden during registration though.Further, I've gone ahead and bundled a transient project reference for
Dapr.WorkflowtoDapr.Workflow.Versioning.Runtimeso developers adding theDapr.Workflow.Versioningproject needn't also include theDapr.Workflowproject itself as that just felt unnecessary.This PR also added unit tests for each of these newly added strategies.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: