Fix timezone-dependent ArgumentOutOfRangeException in WorkflowState#1690
Merged
WhitWaldo merged 3 commits intodapr:masterfrom Feb 2, 2026
Merged
Conversation
Signed-off-by: Daan Schutte <[email protected]>
Signed-off-by: Daan Schutte <[email protected]>
Signed-off-by: Daan Schutte <[email protected]>
WhitWaldo
approved these changes
Feb 2, 2026
Contributor
WhitWaldo
left a comment
WhitWaldo
left a comment
There was a problem hiding this comment.
Looks good to me - happy to merge once tests pass.
Contributor
|
@daanschutte Thank you for identifying and putting this PR together! |
This was referenced Mar 2, 2026
This was referenced Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In WorkflowState, implicit conversion of default(DateTime) to DateTimeOffset can throw ArgumentOutOfRangeException in non-UTC timezones due to underflow. This PR makes the conversion explicit and deterministic by treating workflow metadata timestamps as UTC and guarding against default(DateTime).
Issue reference
Please reference the issue this PR will close: #1689
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: