Skip to content

Correct XML documentation of BulkSubscribeAttribute#1568

Merged
WhitWaldo merged 1 commit intodapr:masterfrom
elKei24:patch-1
Jul 3, 2025
Merged

Correct XML documentation of BulkSubscribeAttribute#1568
WhitWaldo merged 1 commit intodapr:masterfrom
elKei24:patch-1

Conversation

@elKei24
Copy link
Contributor

@elKei24 elKei24 commented Jun 26, 2025

Description

The XML documentation comments of BulkSubscribeAttribute were confusing, probably due to copy-paste without adaption. I changed them to something more helpful.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: N/A

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@elKei24 elKei24 requested review from a team as code owners June 26, 2025 12:12
Copy link
Contributor

@WhitWaldo WhitWaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thank you for spotting and correcting this!

@WhitWaldo WhitWaldo added the documentation Improvements or additions to documentation label Jun 26, 2025
@WhitWaldo WhitWaldo added this to the v1.16 milestone Jun 26, 2025
@WhitWaldo WhitWaldo merged commit 2533c24 into dapr:master Jul 3, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in v1.16 Release Tracking Board Jul 3, 2025
@elKei24 elKei24 deleted the patch-1 branch July 7, 2025 07:00
@marcduiker
Copy link
Contributor

@holopin-bot @elKei24 Thank you Elias! Here's a digital badge as a small token of appreciation.

@holopin-bot
Copy link

holopin-bot bot commented Nov 18, 2025

Congratulations @elKei24, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cmi4hjnzm0005js04fw8t9uy8

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants